-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs(eks-v2-alpha): clarify v2 capacity architecture #35677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a4bb71 to
ab9956f
Compare
| }); | ||
| ``` | ||
|
|
||
| - **Kubectl Handler (Optional)** – A Lambda-backed custom resource created by the AWS CDK to execute `kubectl` commands (like `apply` or `patch`) during deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly confusing - "Optional" implies that the customer can create/specify one (in which case there should be a code example), but the description says that CDK creates the resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more details below, this is more of a summary of the architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Let's link to that section from here so that's clear.
In the summary, every other mode has an example - without linking to more details, this part looks incomplete.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
The readme was incorrectly showing that the default capacity is managed node group, but this is not the case in v2. in V2 the default is EKS auto mode, so the readme was updated to show the current default as the architecture, with some clarification on the other possible capacity modes.
Description of changes
Updated the readme to reflect the state of eks v2.
Describe any new or updated permissions being added
None
Description of how you validated changes
None
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license