Skip to content

Conversation

@aemada-aws
Copy link
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

The readme was incorrectly showing that the default capacity is managed node group, but this is not the case in v2. in V2 the default is EKS auto mode, so the readme was updated to show the current default as the architecture, with some clarification on the other possible capacity modes.

Description of changes

Updated the readme to reflect the state of eks v2.

Describe any new or updated permissions being added

None

Description of how you validated changes

None

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 6, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 6, 2025 08:31
@aemada-aws aemada-aws marked this pull request as ready for review October 6, 2025 08:32
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 6, 2025
@aemada-aws aemada-aws force-pushed the update-v2-readme-eks branch from 4a4bb71 to ab9956f Compare October 21, 2025 15:46
});
```

- **Kubectl Handler (Optional)** – A Lambda-backed custom resource created by the AWS CDK to execute `kubectl` commands (like `apply` or `patch`) during deployment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slightly confusing - "Optional" implies that the customer can create/specify one (in which case there should be a code example), but the description says that CDK creates the resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more details below, this is more of a summary of the architecture.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's link to that section from here so that's clear.

In the summary, every other mode has an example - without linking to more details, this part looks incomplete.

@vishaalmehrishi vishaalmehrishi self-assigned this Oct 24, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f46e8aa into aws:main Oct 24, 2025
19 of 20 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants